commit 718f6eefb6791128a5290b3c7cf47f025ed60c66
author Jens Geyer <jensg@apache.org> 周五 9月 06 21:02:34 2013 +0200
committer Jens Geyer <jensg@apache.org> 周五 9月 06 21:02:57 2013 +0200
tree 6fe7a02497e1d77c3add568137371936581e8a3a
parent a6a32a56fb565d155fd9ae3826b6bbdede6688be

THRIFT-2162 Missing calls to inherited CTOR at misc. places

Patch: Jens Geyer

lib/delphi/src/Thrift.Transport.pas

diff --git a/lib/delphi/src/Thrift.Transport.pas b/lib/delphi/src/Thrift.Transport.pas
index 8668e5a..0d5b384 100644
--- a/lib/delphi/src/Thrift.Transport.pas
+++ b/lib/delphi/src/Thrift.Transport.pas
@@ -502,6 +502,7 @@
 

 constructor TTransportException.Create(AType: TExceptionType);

 begin

+  //no inherited;  

   Create( AType, '' )

 end;

 

@@ -539,17 +540,20 @@
 

 constructor TServerSocketImpl.Create( const AServer: TTcpServer; AClientTimeout: Integer);

 begin

+  inherited Create;

   FServer := AServer;

   FClientTimeout := AClientTimeout;

 end;

 

 constructor TServerSocketImpl.Create( const AServer: TTcpServer);

 begin

+  //no inherited;  

   Create( AServer, 0 );

 end;

 

 constructor TServerSocketImpl.Create(APort: Integer);

 begin

+  //no inherited;  

   Create( APort, 0 );

 end;

 

@@ -616,6 +620,7 @@
 constructor TServerSocketImpl.Create(APort, AClientTimeout: Integer;

   AUseBufferedSockets: Boolean);

 begin

+  inherited Create;

   FPort := APort;

   FClientTimeout := AClientTimeout;

   FUseBufferedSocket := AUseBufferedSockets;

@@ -655,6 +660,7 @@
 

 constructor TServerSocketImpl.Create(APort, AClientTimeout: Integer);

 begin

+  //no inherited;  

   Create( APort, AClientTimeout, False );

 end;

 

@@ -666,27 +672,25 @@
 begin

   FClient := AClient;

   stream := TTcpSocketStreamImpl.Create( FClient);

-  FInputStream := stream;

-  FOutputStream := stream;

+  inherited Create( stream, stream);

 end;

 

 constructor TSocketImpl.Create(const AHost: string; APort: Integer);

 begin

+  //no inherited;  

   Create( AHost, APort, 0);

 end;

 

 procedure TSocketImpl.Close;

 begin

   inherited Close;

-  if FClient <> nil then

-  begin

-    FClient.Free;

-    FClient := nil;

-  end;

+  if FClient <> nil

+  then FreeAndNil( FClient);

 end;

 

 constructor TSocketImpl.Create(const AHost: string; APort, ATimeout: Integer);

 begin

+  inherited Create(nil,nil);

   FHost := AHost;

   FPort := APort;

   FTimeout := ATimeout;

@@ -781,6 +785,7 @@
 

 constructor TBufferedStreamImpl.Create( const AStream: IThriftStream; ABufSize: Integer);

 begin

+  inherited Create;

   FStream := AStream;

   FBufSize := ABufSize;

   FReadBuffer := TMemoryStream.Create;

@@ -916,6 +921,7 @@
 

 constructor TStreamTransportImpl.Create( const AInputStream : IThriftStream; const AOutputStream : IThriftStream);

 begin

+  inherited Create;

   FInputStream := AInputStream;

   FOutputStream := AOutputStream;

 end;

@@ -980,6 +986,7 @@
 

 constructor TBufferedTransportImpl.Create( const ATransport: IStreamTransport);

 begin

+  //no inherited;  

   Create( ATransport, 1024 );

 end;

 

@@ -991,6 +998,7 @@
 constructor TBufferedTransportImpl.Create( const ATransport: IStreamTransport;

   ABufSize: Integer);

 begin

+  inherited Create;

   FTransport := ATransport;

   FBufSize := ABufSize;

   InitBuffers;

@@ -1067,6 +1075,7 @@
 

 constructor TFramedTransportImpl.Create;

 begin

+  inherited Create;

   InitWriteBuffer;

 end;

 

@@ -1077,6 +1086,7 @@
 

 constructor TFramedTransportImpl.Create( const ATrans: ITransport);

 begin

+  inherited Create;

   InitWriteBuffer;

   FTransport := ATrans;

 end;

@@ -1206,6 +1216,7 @@
 

 constructor TTcpSocketStreamImpl.Create( const ATcpClient: TCustomIpClient);

 begin

+  inherited Create;

   FTcpClient := ATcpClient;

 end;